Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some strengthened comments #2448

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Remove some strengthened comments #2448

merged 1 commit into from
Jan 20, 2022

Conversation

pjessesco
Copy link
Contributor

Fixes #2403

@pjessesco pjessesco requested a review from a team as a code owner December 27, 2021 10:11
Copy link
Contributor

@fsb4000 fsb4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: constexpr default_sentinel_t end() const noexcept doesn't have strengthened comment, so we don't remove the comment here.

STL/stl/inc/ranges

Lines 3513 to 3515 in 303df3d

_NODISCARD constexpr default_sentinel_t end() const noexcept {
return default_sentinel;
}

@mnatsuhara
Copy link
Contributor

Thanks for your contribution! Many of the maintainers are currently "out of the (virtual) office" due to the end-of-the-year US holidays, so it may take us a little longer to review your changes due to reduced bandwidth. Thanks for your patience, we'll take a look as soon as we can! 😄

@CaseyCarter CaseyCarter added the documentation Related to documentation or comments label Dec 29, 2021
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Jan 12, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jan 12, 2022
@StephanTLavavej StephanTLavavej removed their assignment Jan 19, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jan 19, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 086b072 into microsoft:main Jan 20, 2022
@StephanTLavavej
Copy link
Member

Thanks for updating these comments to align with the current Working Paper - and congratulations on your first microsoft/STL commit! 🚀 😸 ✅

This will appear in VS 2022 17.2 Preview 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments LWG Library Working Group issue
Projects
None yet
5 participants