Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untag dispatch string constructor #2480

Merged
merged 7 commits into from
Mar 2, 2022
Merged

Untag dispatch string constructor #2480

merged 7 commits into from
Mar 2, 2022

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented Jan 15, 2022 •
edited
Loading

Towards #189

It might be worth to:

Currently it isn't done, only pure untag dispatch.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner January 15, 2022 16:31
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Jan 16, 2022
@CaseyCarter CaseyCarter self-assigned this Feb 23, 2022
CaseyCarter
CaseyCarter approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unnecessary per-character capacity checks after reserve for the forward case make me a sad panda, but are pre-existing.

@CaseyCarter CaseyCarter removed their assignment Feb 24, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 1, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9fe98e0 into microsoft:main Mar 2, 2022
@StephanTLavavej
Copy link
Member

Thanks for improving compiler throughput in this popular class! 🧶 🐈 😸

@AlexGuteniev AlexGuteniev deleted the untag_dispatch_string_ctor branch March 19, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter