Speculatively implement LWG-3664 #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix a regression when calling `ranges::distance` with array arguments which _should_ decay to pointers.
miscco
approved these changes
Feb 6, 2022
StephanTLavavej
approved these changes
Feb 6, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
timsong-cpp
reviewed
Feb 6, 2022
Merge `distance(i, s)` overloads to use `if constexpr` dispatch instead of concept overloading.
StephanTLavavej
approved these changes
Feb 6, 2022
|
I pushed one more commit to directly use |
|
Thanks @timsong-cpp for paying enough attention to catch my bug on a weekend. For posterity: I bypassed branch policy to merge this with only one maintainer review due to time crunch. We did have some contributor reviews to add confidence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix a regression when calling
ranges::distancewith array arguments which should decay to pointers.If you look at LWG-3664 soon, you'll notice this doesn't match the proposed resolution. That original P/R is insufficient (Outlook Code™). Yes, that's right, the fix I suggested for the regression resulting from the fix I made in LWG-3392 is broken. :thonk: I've sent an updated PR with this change to LWG Chair, it will be a few days before the issue gets updated.