Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __cpp_lib_concepts #2559

Merged
merged 3 commits into from
Feb 12, 2022
Merged

Update __cpp_lib_concepts #2559

merged 3 commits into from
Feb 12, 2022

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Feb 11, 2022

... to the post-P1964R2 value of 202002L. (Yes, we dropped the ball nearly two years ago.)

I've added this to my unofficial list of things to be sure to backport.

I fully audited SD-6 against our feature-test macros, the only other discrepancy is that we don't define __cpp_lib_deduction_guides which sd-6 does because LWG-3635 hasn't yet decided if we want that macro or not.

... to the P1964R2 value of `202002L`. (Yes, we dropped the ball nearly two years ago.)
@CaseyCarter CaseyCarter added the bug Something isn't working label Feb 11, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner February 11, 2022 04:20
@CaseyCarter CaseyCarter changed the title Update __cpp_lib_concepts Update __cpp_lib_concepts Feb 11, 2022
@StephanTLavavej StephanTLavavej self-assigned this Feb 11, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo. Requesting or pushing changes is totally fine, but please notify me if that happens.

@StephanTLavavej StephanTLavavej merged commit afe0800 into microsoft:main Feb 12, 2022
@StephanTLavavej
Copy link
Member

Thanks for finding and fixing this ancient bug! 🐞 🔎 ✅

@CaseyCarter CaseyCarter deleted the sd6 branch February 12, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants