-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1413R3 Deprecate aligned_storage
& aligned_union
#2583
P1413R3 Deprecate aligned_storage
& aligned_union
#2583
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the non-deprecated copy is not needed, but I'm not sure.
# Conflicts: # tests/libcxx/expected_results.txt # tests/libcxx/skipped_tests.txt # tests/libcxx/usual_matrix.lst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! I found only nitpicks, so I'll validate and push changes soon.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for implementing this C++23 feature and helping to modernize the ecosystem! 🧑🚀 🚀 🪐 |
Co-authored-by: Stephan T. Lavavej <[email protected]>
Resolves #2533
Internal use in
mutex
/condition_variable
/node_handle
- is fixed by creating a non-deprecated copy.I'm not sure why we quote the deprecating paper, as we don't quote the WP merged papers elsewhere; but I followed the precedent.