-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache _Fmt_codec<char, false>
#2600
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, though someone who understands more about object lifetime should look at the caching component.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for improving |
This is an alternative to #2596.
Fixes #2594
I thought of simply returning a global
_Fmt_codec<char>
object in_Get_fmt_codec<char>()
, but I think this might makestd::format
unusable in initialization of variable template instances. (The standard says that such initializations are unordered with other initializations.)