Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid relink msvcp140_atomic_wait_oss.dll #2606

Merged
merged 1 commit into from
Mar 17, 2022
Merged

avoid relink msvcp140_atomic_wait_oss.dll #2606

merged 1 commit into from
Mar 17, 2022

Conversation

crackedmind
Copy link
Contributor

Resolves #2605

From cmake help:
Generated files are modified and their timestamp updated on subsequent cmake runs only if their content is changed.

@crackedmind crackedmind requested a review from a team as a code owner March 13, 2022 09:48
@StephanTLavavej StephanTLavavej added the build Related to the build system label Mar 14, 2022
@StephanTLavavej
Copy link
Member

Verified that this works as expected, thank you! 😻

CaseyCarter
CaseyCarter approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that relinking doesn't occur after running cmake with no changes for a completed build.

@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej self-assigned this Mar 15, 2022
@StephanTLavavej StephanTLavavej merged commit 4ad4c95 into microsoft:main Mar 17, 2022
@StephanTLavavej
Copy link
Member

Thanks for fixing the build system for optimal incremental builds! 😻 😻 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
build Related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stl/CMakeLists.txt: Rerunning CMake relinks msvcp140_atomic_wait_oss.dll unnecessarily
3 participants
@crackedmind @StephanTLavavej @CaseyCarter