change SFINAE constraint on construct_at (MSVC workaround)
#2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: A. Jiang <[email protected]>
CaseyCarter
requested changes
Mar 29, 2022
miscco
reviewed
Mar 30, 2022
CaseyCarter
approved these changes
Mar 30, 2022
StephanTLavavej
approved these changes
Mar 30, 2022
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
approved these changes
Mar 30, 2022
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
approved these changes
Mar 31, 2022
StephanTLavavej
approved these changes
Apr 1, 2022
This comment was marked as outdated.
This comment was marked as outdated.
|
Unfortunately, this is blocked by VSO-1513874 "Changing |
raghavthind2005
approved these changes
Apr 30, 2022
StephanTLavavej
added
blocked on 17.3p2
and removed
blocked
|
The blocking bug has been fixed for 17.3 Preview 2 (I confirmed that this was one of the last fixes to get in). |
StephanTLavavej
approved these changes
Jun 16, 2022
|
I've pushed a merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Jun 19, 2022
|
Thanks for finding out how to exceed the compiler's correctness! ✅ ✅ ✅ |
fsb4000
added a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…ft#2624) Co-authored-by: A. Jiang <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2620
EDG gives error on both version of the constraint.
Also the Developer Community has a maintenance now, so I'll create DevCom bugs later(about EDG and MSVC)