Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce _Invoker_ret specializations with if constexpr #2668

Merged
merged 4 commits into from
May 5, 2022
Merged

Reduce _Invoker_ret specializations with if constexpr #2668

merged 4 commits into from
May 5, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Towards #189

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner April 23, 2022 12:21
miscco
miscco approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the noexcept specification is indeed equivalent

@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Apr 26, 2022
@StephanTLavavej StephanTLavavej self-assigned this Apr 27, 2022
@strega-nil-ms strega-nil-ms removed their assignment May 3, 2022
@StephanTLavavej StephanTLavavej self-assigned this May 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0a618df into microsoft:main May 5, 2022
@AlexGuteniev AlexGuteniev deleted the unspecialize branch May 5, 2022 09:14
@StephanTLavavej
Copy link
Member

Thanks for improving throughput in this important codepath! (The invoke family is one of the most heavily instantiated.) 🚀 😻 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @miscco @strega-nil-ms