Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untag dispatch <random> #2693

Merged
merged 10 commits into from
May 5, 2022
Merged

Untag dispatch <random> #2693

merged 10 commits into from
May 5, 2022

Conversation

AlexGuteniev
Copy link
Contributor

@AlexGuteniev AlexGuteniev commented May 2, 2022 •
edited
Loading

Towards #189

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner May 2, 2022 06:58
miscco
miscco reviewed May 2, 2022
View reviewed changes
stl/inc/random Outdated Show resolved Hide resolved
stl/inc/random Outdated Show resolved Hide resolved
stl/inc/random Outdated Show resolved Hide resolved
AlexGuteniev and others added 5 commits May 2, 2022 10:54
@AlexGuteniev @miscco
Update stl/inc/random
4aa7999 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@AlexGuteniev @miscco
Update stl/inc/random
5b2fada 
Co-authored-by: Michael Schellenberger Costa <[email protected]>
@AlexGuteniev
match trait
cf2c375
@AlexGuteniev
simplify
c3841c9
@AlexGuteniev
numeric value
9e5bb22
@CaseyCarter CaseyCarter added the enhancement Something can be improved label May 2, 2022
@StephanTLavavej StephanTLavavej added throughput Must compile faster and removed enhancement Something can be improved labels May 3, 2022
@strega-nil-ms strega-nil-ms self-assigned this May 4, 2022
strega-nil-ms
strega-nil-ms suggested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_Seed does not need to be a template; additionally, an existing narrowing conversion stops working with these changes.

stl/inc/random Outdated Show resolved Hide resolved
stl/inc/random Outdated Show resolved Hide resolved
@strega-nil-ms

This comment was marked as resolved.

Sign in to view
@strega-nil
switch to enable_if instead of if constexpr
21ae3d5 
this is more in line with the standard, and allows us to remove `_Seed`
@strega-nil
fix compilation
6f53446
@strega-nil-ms
Copy link
Contributor

I've pushed changes that fix my comments

@strega-nil-ms strega-nil-ms removed their assignment May 4, 2022
@strega-nil-ms strega-nil-ms mentioned this pull request May 4, 2022
Closed
@StephanTLavavej StephanTLavavej removed their assignment May 4, 2022
@StephanTLavavej StephanTLavavej self-assigned this May 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit cf15d6c into microsoft:main May 5, 2022
@StephanTLavavej
Copy link
Member

Thanks for delving into this ancient header and solving this puzzle! 😹 🧩 🎉

@AlexGuteniev AlexGuteniev deleted the untag_dispatch_random branch May 5, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexGuteniev @strega-nil-ms @StephanTLavavej @miscco @CaseyCarter @strega-nil