Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untag dispatch vector<👻>::_Insert #2694

Merged
merged 3 commits into from
May 5, 2022
Merged

Untag dispatch vector<👻>::_Insert #2694

merged 3 commits into from
May 5, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Towards #189

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner May 2, 2022 11:18
miscco
miscco reviewed May 2, 2022
View reviewed changes
stl/inc/vector Outdated Show resolved Hide resolved
@AlexGuteniev AlexGuteniev changed the title Untag dispatch vector _Insert Untag dispatch vector<👻>::_Insert May 2, 2022
@CaseyCarter CaseyCarter added the enhancement Something can be improved label May 2, 2022
@StephanTLavavej StephanTLavavej added throughput Must compile faster and removed enhancement Something can be improved labels May 3, 2022
CaseyCarter
CaseyCarter approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll apply my renaming suggestion and approve.

stl/inc/vector Outdated Show resolved Hide resolved
stl/inc/vector Outdated Show resolved Hide resolved
stl/inc/vector Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej mentioned this pull request May 4, 2022
Open
@StephanTLavavej StephanTLavavej self-assigned this May 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit bebd80e into microsoft:main May 5, 2022
@StephanTLavavej
Copy link
Member

👻 😸 👻

@AlexGuteniev AlexGuteniev deleted the untag_dispatch_vector branch May 5, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @miscco