<xmemory>: Remove std::allocator<void> full specialization
#2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove non-Standard member types.
related to std::allocator<void>.
Add mysterious spaces.
CaseyCarter
requested changes
May 18, 2022
tests/std/tests/GH_000527_remove_allocator_void/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
approved these changes
May 18, 2022
tests/std/tests/GH_000527_remove_allocator_void/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
May 20, 2022
|
Thanks! I pushed a couple of style changes. |
CaseyCarter
approved these changes
May 20, 2022
| #endif | ||
|
|
||
| STATIC_ASSERT(has_cxx20 == has_member_size_type<allocator<void>>); |
There was a problem hiding this comment.
Pure style, and totally not worth resetting testing if we change nothing else: I would have written these as [Actual value] == [Expected value], which I think is more consistent with our test conventions.
There was a problem hiding this comment.
That's my preferred style too - but I did it this way so that they would line up, and make the pattern obvious.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this C++20 conformance issue! ✅ 😸 🚀 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…soft#2726) Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of
std::allocator<void>full specialization is observable via SFINAE techniques. As of C++20, usingstd::allocator<void>::allocateis no longer a substitution failure, but a hard error. This PR tests such changes.This PR also removes
propagate_on_container_move_assignmentandis_always_equalfromstd::allocator<void>full specialization according to N4659. It seems that MSVC STL applied LWG-2103 and LWG-2108 (WG21-N4258) tostd::allocator<void>full specialization, but these member types haven't gone intostd::allocator<void>in C++17, see N4659 [depr.default.allocator].Works towards WG21-P0619.
Fixes #527.