Avoid an assertion failure in alias.asm #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
May 24, 2022
StephanTLavavej
approved these changes
May 24, 2022
|
@barcharcraz @CaseyCarter Thanks! 😻 I pushed a trivial comment change (to restore a grammar fix that I had applied to the original PR before merging). I also verified all of the mangled names for x86 and x64. Mirroring now... |
CaseyCarter
approved these changes
May 24, 2022
|
@barcharcraz discovered that demacroizing wasn't sufficient to avoid the internal assertion, but that splitting up this asm file, so that there's one file per function, works. I have pushed changes to do this. |
CaseyCarter
approved these changes
May 25, 2022
StephanTLavavej
approved these changes
May 25, 2022
|
Thanks for fixing this (again)! 😹 😹 🐱 🐱 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the thing about requiring <> around the parameters of the ALIAS directive was for real. If they are actually needed, I think it's impossible to use macros to generate that directive, so I have removed the macros and duplicated the directives.
This actually makes the file somewhat simpler and easier to read, I think it was overly clever and compressed before.