[aliasobj] just build the alias objects once #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got annoyed at the continual `Assembling:` lines
CaseyCarter
approved these changes
May 26, 2022
StephanTLavavej
requested changes
May 26, 2022
|
Note that I think the debug and release aliasobjs may actually be different in relevant ways (in that the debug ones have debugger information for the added symbols. |
StephanTLavavej
requested changes
May 27, 2022
I'm not sure if the `alternate_name_broke_linker` test is still broken, but it does work on my machine
|
@barcharcraz having looked at the resulting COFF files, there doesn't seem to be a difference (two bytes difference excepting file name and date/time) |
StephanTLavavej
approved these changes
May 28, 2022
barcharcraz
approved these changes
May 31, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for simplifying this new part of the build! 🎉 ✅ 😸 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Nicole Mazzuca <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed at the continual
Assembling:linescc @barcharcraz
this shouldn't change output at all, but it will make it so we only build the asm files once.
it is also extremely unimportant.