-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support char8_t in C++17 and C++14 modes #2748
Conversation
Is there any reason to accept (or regularize) the "C++17 with |
Probably because |
Maybe I should create |
Yeah, changes to the usual matrices are extremely expensive because the cost of each configuration is multiplied by the large number of tests. Also, when they're changed, typically the native matrix and others need to be changed. Since relatively little code is sensitive to this setting, I like your idea of creating a new matrix (or matrices) for a new test (or a small number of new tests). A single matrix with both C++14 and C++17 modes, with a test that has C++17-only components guarded by |
IMO we should also consider deprecation of
|
Thanks, this looks great! I verified that all |
Co-authored-by: Casey Carter <[email protected]>
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for making this Future Technology available to C++14/17 users! 🚀 🛸 😸 |
Co-authored-by: Stephan T. Lavavej <[email protected]> Co-authored-by: Casey Carter <[email protected]>
Fixes #2106