Don't assume that _Hash_vec's size and capacity are always equal
#2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior implementation that used `vector` directly had bugs that sometimes result in differing size and capacity. Since old and new code have may link, we need to tolerate this condition. Fixes DevCom-1190124/VSO-1220461
|
My current thinking is that we can't test this non-intrusively, and any intrusive test would require more changes to the code than does the fix, so it's probably not worthwhile. I'm happy to hear any suggestions. |
CaseyCarter
changed the title
_Hash_vec's size and capacity are always equal
StephanTLavavej
requested changes
Jun 9, 2022
StephanTLavavej
requested changes
Jun 9, 2022
StephanTLavavej
approved these changes
Jun 9, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for finding out how to fix this bincompat break! 🏚️ 🛠️ 🏡 |
|
Can this be fixed for 2019 16.11 STL? |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior implementation that used
vectordirectly had bugs that sometimes result in differing size and capacity. Since old and new code may link, we need to tolerate this condition.Fixes DevCom-1190124/VSO-1220461/AB#1220461