Include <cmeow> instead of <meow.h>, Part2

[fsb4000]

While reviewing #2851 I found that tests/std/tests/Dev11_0836436_get_time/test.cpp includes #include <assert.h> and other .h files.
I recall that we already replaced <meow.h> to <cmeow>. I found the PR: #1405

There are still some places where we include <meow.h>:
tr1 tests
benchmarks\inc\xoshiro.hpp (because Written in 2018 by David Blackman and Sebastiano Vigna ([email protected]))
__msvc_all_public_headers.hpp
<cmeow>
tests\std\include\force_include.hpp (because Part of the LLVM Project)
tests with // LLVM SOURCES BEGIN (tests\std\tests\P0088R3_variant\test.cpp for example)

[strega-nil-ms]

I don't love that the namespaces are changed in this PR, given it's unnecessary AFAIK; additionally, I'm personally at least very much against using std:: to access C functions and types.

[fsb4000]

clang-format aligning = default/= delete, no manual changes.

oops, I already updated clang to 14.
I will merge main and restart pipeline after the toolset update.

[strega-nil-ms]

thanks!

[StephanTLavavej]

Thanks, this looks good. I've verified that everything that should be changed, is being changed with no missed occurrences, except for the exclusions as noted in the PR description.

As mentioned in a comment, I'm nervous about changing the header units test here - I think we should go back to including the UCRT headers, with added comments.

My last concern is that this is an extremely large PR in terms of the number of files being edited, so we should try to be extra clean about "nice to have" changes that are not strictly necessary for the central intent of the PR. There are a small number of namespace changes, and two of those files were missing changes, which is easily missed in such a large PR.

As much as I love using namespace std; in tests (I prefer for all tests in tests/std to use using-directives, unless they are one of the unusual ones that is specifically concerned with namespaces like the UDL test), and while we could add additional changes to patch the affected files, I would strongly prefer to remove these changes from the PR so that it's completely focused on the <cmeow> transformation - easily verified with git diff -U0 and grep filtering.

I've verified and will push changes. With this, I am confident that the PR shouldn't disrupt tests.

[StephanTLavavej]

@strega-nil-ms FYI, I pushed changes after you approved.

[strega-nil-ms]

@StephanTLavavej's changes LGTM! Thanks.

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[StephanTLavavej]

I've pushed a merge with main to resolve a simple merge conflict with #2125 in <charconv> (delete/modify). Accepted delete, as #2125 pre-emptively resolved this conflict in its moved code.

[StephanTLavavej]

cthanks cfor cthis cconsistency cimprovement! 😹 🎉 🤪