Implement P2417R2 More constexpr bitset
#2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperWig
reviewed
Jul 30, 2022
Co-authored-by: A. Jiang <[email protected]>
CaseyCarter
requested changes
Jul 30, 2022
Co-authored-by: Casey Carter <[email protected]>
Co-authored-by: Casey Carter <[email protected]>
CaseyCarter
approved these changes
Jul 30, 2022
StephanTLavavej
approved these changes
Aug 1, 2022
|
@fsb4000 @CaseyCarter I've pushed a correctness fix and a significant expansion of test coverage; please double-check. |
CaseyCarter
approved these changes
Aug 1, 2022
miscco
approved these changes
Aug 2, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
strega-nil-ms
approved these changes
Aug 3, 2022
| @@ -32,41 +32,41 @@ public: | |||
| friend bitset<_Bits>; | |||
|
|
|||
| public: | |||
| ~reference() noexcept {} // TRANSITION, ABI | |||
| _CONSTEXPR23 ~reference() noexcept {} // TRANSITION, ABI | |||
There was a problem hiding this comment.
I think these should technically be constexpr always (or I guess _CONSTEXPR20 for constexpr destructors), but since one can't create one of these at constexpr time until 23, I don't think it matters.
No change requested.
|
Thanks for setting this bit in the C++23 conformance |
strega-nil
pushed a commit
to strega-nil/stl
that referenced
this pull request
Aug 6, 2022
Co-authored-by: Daniel Marshall <[email protected]> Co-authored-by: A. Jiang <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
fsb4000
added a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Daniel Marshall <[email protected]> Co-authored-by: A. Jiang <[email protected]> Co-authored-by: Casey Carter <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2926
I added a new test file because the previous
bitsettest istr1/bitsetand we don't changetr1tests.