Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-strict matrices where possible #3015

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Use non-strict matrices where possible #3015

merged 1 commit into from
Aug 12, 2022

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Aug 9, 2022 •
edited
Loading

We've been a bit lax about using the strict_concepts_meow test matrices, which omit /permissive configs, when we don't really need to. Use the plain concepts_meow matrices instead for tests that pass with /permissive.

After this, the remaining strict tests are:

  • P0323R12_expected
  • P0896R4_common_iterator
  • P0896R4_views_drop
  • P0896R4_views_elements
  • P0896R4_views_filter
  • P0896R4_views_filter_death
  • P0896R4_views_filter_iterator
  • P0896R4_views_join
  • P0896R4_views_lazy_split
  • P0896R4_views_split
  • P0896R4_views_take
  • P0896R4_views_transform
  • P1522R1_difference_type
  • P1899R3_views_stride
  • P2441R2_views_join_with

@CaseyCarter
Use non-strict matrices where possible
0e91e79 
We've been a bit lax about using the `strict_concepts_meow` test matrices which omit `/permissive` configs. Use the plain `concepts_meow` matrices instead for tests that pass with `/permissive`.
@CaseyCarter CaseyCarter added the test Related to test code label Aug 9, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner August 9, 2022 20:40
@strega-nil-ms strega-nil-ms self-assigned this Aug 10, 2022
@strega-nil-ms strega-nil-ms removed their assignment Aug 10, 2022
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 11, 2022
Merged
@StephanTLavavej StephanTLavavej self-assigned this Aug 11, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0a44c23 into microsoft:main Aug 12, 2022
@StephanTLavavej
Copy link
Member

No one can be told what the non-strict matrix is - you have to compile it for yourself. 🕶️ 🖥️ 💊

@CaseyCarter CaseyCarter deleted the strictly-ballroom branch August 13, 2022 06:12
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 23, 2022
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyCarter @StephanTLavavej @strega-nil-ms