Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolset update: VS 2022 17.4 Preview 1 #3017

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Toolset update: VS 2022 17.4 Preview 1 #3017

merged 5 commits into from
Aug 12, 2022

Conversation

StephanTLavavej
Copy link
Member

  • Python 3.10.6.
  • New pool.
    • Contains Aug 2022's Patch Tuesday.
  • README.md: VS 2022 17.4 Preview 1, Ninja 1.11.0.
  • Require MSVC 19.34.
    • The MSVC-internal build is already using a checked-in 19.34 compiler.
  • Attempt to remove workaround for internal VSO-284079 "C1XX's C++14 constexpr emits bogus warnings C4146, C4308, C4307 for basic_string_view::iterator".
    • Although this bug hasn't been updated in 3 years, I observe that the warnings no longer repro. Let's try to activate this test coverage now.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Aug 10, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 10, 2022 01:13
@strega-nil-ms strega-nil-ms self-assigned this Aug 10, 2022
strega-nil-ms
strega-nil-ms approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stephan!

@strega-nil-ms strega-nil-ms removed their assignment Aug 10, 2022
@StephanTLavavej StephanTLavavej self-assigned this Aug 11, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4c8d0ae into microsoft:main Aug 12, 2022
@StephanTLavavej StephanTLavavej deleted the vs-17.4p1 branch August 12, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
infrastructure Related to repository automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephanTLavavej @CaseyCarter @strega-nil-ms