Unwrappable iter/sent pairs! #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CaseyCarter how do you feel about my new version? |
I feel like the code formatting could be better 🥁 (looking now). |
CaseyCarter
reviewed
Aug 11, 2022
…ng-with-sentinels
…ng-with-sentinels
|
It's always fun finding weird bugs in the compiler |
StephanTLavavej
requested changes
Aug 19, 2022
|
@strega-nil-ms Now that #2987 has landed, there's a merge conflict in |
…ng-with-sentinels
|
@StephanTLavavej it has been moiged! |
CaseyCarter
approved these changes
Aug 29, 2022
StephanTLavavej
requested changes
Aug 30, 2022
tests/std/tests/GH_002992_unwrappable_iter_sent_pairs/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/GH_002992_unwrappable_iter_sent_pairs/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_002992_unwrappable_iter_sent_pairs/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_002992_unwrappable_iter_sent_pairs/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Aug 30, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Aug 31, 2022
|
Thanks for unwrapping these iterators and sentinels so cats can play with the wrapping paper! 🐈 🎁 🐈⬛ |
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing machinery leaves much to be desired, see #2992. This will hopefully fix those issues.
Requires tests