Cleanup tests to be friendlier to modules #3034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimentally running
tests/std
with Standard Library Modules, I encountered unnecessary dependencies on macros and non-Standard code. Although we're a long way from routinely running module configurations intests/std
, I'd like to clean up what I've found so far._Is_any_of_v
. We can useis_same_v
instead of this internal machinery, at minimal verbosity cost.numeric_limits
instead of macros.std::integral
,std::numbers
,std::expected
. Afterimport std; using namespace std;
, if test code has global-scopeintegral
,numbers
, andexpected
, mentioning them unqualified is ambiguous. (This is theoretically an issue for headers too, as any header is allowed to drag in any other header.)<cinttypes>
print macros. These are difficult to read in any event, andstatic_cast
s are probably less annoying.