add __forceinline to std::unreachable instead of inline

[fsb4000]

Co-authored-by: Alexander Bessonov [email protected]

From #3051

And we already use __forceinline there:

STL/stl/inc/xcharconv_ryu.h

Line 166 in febb643

_NODISCARD __forceinline uint64_t __ryu_umul128(const uint64_t __a, const uint64_t __b, uint64_t* const __productHi) {

[strega-nil-ms]

This looks extremely reasonable to me, personally - we know that MSVC does not consider [[noreturn]] functions for inlining unless they're marked with __forceinline. I would like to see what the opinions of the other maintainers are, though.

[strega-nil-ms]

If the rest of the team thinks this is reasonable, this is obviously the correct way to implement this.

[StephanTLavavej]

I agree with @strega-nil-ms, and @AlexBAV's codegen example https://godbolt.org/z/a9d33hc5b shows that this makes a difference for /O2. In __ryu_umul128, the use of __forceinline was a compiler workaround (marked TRANSITION), but here the compiler's behavior regarding [[noreturn]] is reasonable and so __forceinline is also a reasonable perma-workaround. (The Ryu/charconv usage proves that __forceinline shouldn't cause other issues due to its non-Standardness.)

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[StephanTLavavej]

Thanks for improving the STL's performance to previously unreachable levels! 📈 🚀 😹

[AlexBAV]

Thanks for improving the STL's performance to previously unreachable levels! 📈 🚀 😹

You're always welcome :)