Move assignment of xchar to declaration #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows best practices without changing behavior
AlexGuteniev
approved these changes
Sep 8, 2022
StephanTLavavej
approved these changes
Sep 9, 2022
|
Thanks, this is a clear improvement! I pushed a commit for an additional occurrence in the |
strega-nil-ms
approved these changes
Sep 12, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Sep 13, 2022
| @@ -8,10 +8,9 @@ | |||
| _EXTERN_C_UNLESS_PURE | |||
|
|
|||
| short _Dnorm(_Dval* ps) { // normalize double fraction | |||
| short xchar; | |||
| short xchar = 1; | |||
There was a problem hiding this comment.
The scope is small enough here as to make no difference, but in the future I suggest moving the declaration to the initialization in preference to moving the initialization to the declaration. We generally try to limit the lifetime of objects to the portion of the code that actually uses those objects.
|
Thanks for this code cleanup! 😸 😸 😸 😸 😸 😸 😸 |
CaseyCarter
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows best practices without changing behavior