-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict ADL for reference_wrapper
and thread
#3101
Restrict ADL for reference_wrapper
and thread
#3101
Conversation
For `reference_wrapper` and `thread`. And update the references to the latest Working Draft as driven-by change.
Marking |
Removing |
Oh, I'm sorry for doing too much in one commit.😹 This PR does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me! Thanks!
Thanks - I've pushed small changes to fix citations, clarify a comment, and remove unnecessary parens. FYI @strega-nil-ms (as you previously approved) and @CaseyCarter (if you want to double-check the citation that you added in 2019). ✅ No modules impact. |
I'm not enthusiastic about section numbers in our working draft citations - they're just noise - but it's not worth the effort to pull them out at this point. |
I can go with removal of section numbers. Should we make an issue to track this? |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for investigating and fixing these libcxx test failures! 🚀 😻 📉 |
@frederick-vs-ja We already had #182, so I updated that issue to mention that section numbers should be dropped. |
This PR is unblocking two libcxx tests.
std/thread/thread.threads/thread.thread.class/thread.thread.constr/robust_against_adl.pass.cpp
std/utilities/function.objects/refwrap/refwrap.invoke/robust_against_adl.pass.cpp
Driven-by changes:
path
's comparison operators are IF-NDR #2358 is fixed, but the related libcxx test still fails because it requirespath
's iterator to satisfybidirectional_iterator
. The explanation should be changed.<type_traits>
and<thread>
are updated to WG21-N4917 with section numbers added.