Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable P0943R6_stdatomic_h test for clang #3186

Merged
merged 1 commit into from
Nov 11, 2022
Merged

enable P0943R6_stdatomic_h test for clang #3186

merged 1 commit into from
Nov 11, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Oct 31, 2022

Fixes #2862

@fsb4000 fsb4000 requested a review from a team as a code owner October 31, 2022 01:00
strega-nil-ms
strega-nil-ms approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks <3

@StephanTLavavej StephanTLavavej added the test Related to test code label Oct 31, 2022
@StephanTLavavej StephanTLavavej self-assigned this Nov 11, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0743f64 into microsoft:main Nov 11, 2022
@StephanTLavavej
Copy link
Member

Thanks for improving the test coverage here! 📈 🎉 😸

@fsb4000 fsb4000 deleted the fix2862 branch November 12, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clang 14's <stdatomic.h> is incompatible with MSVC's <stdatomic.h> ☢️
4 participants
@fsb4000 @StephanTLavavej @CaseyCarter @strega-nil-ms