standardize ^^^ x / !x vvv comments
#3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this PR also settle on double arrows or one on each side i.e. |
|
Sure, and what do you like more? |
|
My vote would for the second. I believe this is also part of #351 |
|
I'll take a look at this once we discuss #351 |
strega-nil-ms
suggested changes
Nov 28, 2022
strega-nil-ms
changed the title
// => / in comments^^^ x / !x vvv comments
strega-nil-ms
approved these changes
Dec 1, 2022
StephanTLavavej
approved these changes
Dec 5, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks again for this consistency pass! 😸 🎉 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we use
// ^^^ no workaround / workaround vvvand sometimes// ^^^ no workaround // workaround vvv.It looks like
/is used more often. So I replaced all of//which I had found.I used
//.+//regexp and VS code.Driven by: #3206 (comment)