Update comments for approved LWG issues #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need comments for LWG issues that are now Standard. This includes comment cleanup for: * LWG-3569, * LWG-3766, and * LWG-3788. This also removes `/* strengthened */` comments for functions that are now `noexcept`: * `atomic_meow` functions made `noexcept` LWG-3745, and * `reference_wrapper::operator()` made conditionally `noexcept` by LWG-3764.
58 tasks
AraHaan
reviewed
Nov 17, 2022
AraHaan
approved these changes
Nov 17, 2022
StephanTLavavej
approved these changes
Nov 17, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for aligning the codebase with the latest Working Draft! 😸 🎉 🐈 |
|
|
``// Use 'postCreateCommand' to run commands after the container is created. |
|
@Tojfel are these intentional posts? I have no idea what you're trying to say. |
|
I think they accidentally posted those here when they intended to post them in another repository. I am also guilty of that sometimes too when tabs blend in from edge shortening tab lengths to just the icons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need comments for LWG issues that are now Standard. This includes comment cleanup for:
This also removes
/* strengthened */comments for functions that are nownoexcept:atomic_meowfunctions madenoexceptby LWG-3745, andreference_wrapper::operator()made conditionallynoexceptby LWG-3764.