Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement P2167R3 Improving boolean-testable Usage (for comparison fallback CPOs) #3258

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #3211. I believe that these changes should be applied to C++20 mode, as the paper is very near to an LWG DR.

No change is needed for the rest of P2167R3, because it's "something that increases the restrictions placed on users, but implementers aren't expected to enforce those restrictions".

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner December 2, 2022 18:17
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Dec 3, 2022
@strega-nil-ms strega-nil-ms added the decision needed We need to choose something before working on this label Dec 5, 2022
@strega-nil-ms
Copy link
Contributor

Marking decision needed as this changes C++20 code; I personally believe that it should be treated as a DR tho.

@StephanTLavavej
Copy link
Member

I'm in favor of implementing this basically-a-bugfix paper in C++20 mode. This is consistent with our usual policy: major features (especially those introducing any new names) are always guarded, but if it's a similar size to an LWG issue resolution, avoids disrupting all but the most pathological user code, and affects existing product code that would be a pain to maintain two variants of, then implementing it downlevel is reasonable. (The enable_shared_from_this overhaul is the prime example, and this feels very similar.)

@strega-nil-ms strega-nil-ms removed the decision needed We need to choose something before working on this label Dec 5, 2022
@strega-nil-ms
Copy link
Contributor

Alright, I'm good with that then.

@StephanTLavavej StephanTLavavej self-assigned this Dec 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 298d586 into microsoft:main Dec 6, 2022
@StephanTLavavej
Copy link
Member

Thanks for investigating and implementing the necessary changes here! ✅ 🕵️ 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx23 C++23 feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2167R3 Improving boolean-testable Usage
3 participants