Fix for std::numeric_limits<std::_Signed128>::is_signed
#3291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've noticed that the MSVC's STL provides
std::numeric_limits
template specializationfor the
std::_Signed128
(a type which models thesigned-integer-class
concept) slightly incorrectly,that is the
std::numeric_limits<std::_Signed128>::is_signed
isfalse
instead oftrue
:This change fixes that issue and adds a couple of compile-time checks
verifying that the
std::numeric_limits<std::_Signed128>
is properly specialized.