-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Boost to 1.81 #3312
Update Boost to 1.81 #3312
Conversation
This assertion failed, but I failed to reproduce the error on Godbolt...
Perhaps we can (temporarily) change this line as indicated ( assert(expect_epsilons(comp_ellint_2(0), acos(-1.0) / 2, 2)); |
You also need to update this commit hash to Lines 8 to 9 in 8ddf4da
|
I will be the first to say it; I did in fact contribute to this release of Boost. However, it fixes a platitude of issues as this is a bugfix release. Therefore, I think updating to 1.81 is worth it.
Done! |
@frederick-vs-ja Do we need to create an issue about this (here or maybe in boost-math repo)? |
I think I've reproduced the error, so I reported the issue in boost-math repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I've verified that the commit hash corresponds to the boost-1.81.0 tag in the boost-math repo (https://github.com/boostorg/math/tags).
Adding |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for updating the Boost.Math dependency! ✅ 🎉 😸 |
I will be the first to say it; I did in fact contribute to this release of Boost. However, it fixes a platitude of issues as this is a bugfix release.
Therefore, I think updating to 1.81 is worth it.