Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Boost to 1.81 #3312

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Update Boost to 1.81 #3312

merged 3 commits into from
Jan 12, 2023

Conversation

AreaZR
Copy link
Contributor

@AreaZR AreaZR commented Dec 29, 2022

I will be the first to say it; I did in fact contribute to this release of Boost. However, it fixes a platitude of issues as this is a bugfix release.

Therefore, I think updating to 1.81 is worth it.

@AreaZR AreaZR requested a review from a team as a code owner December 29, 2022 18:49
@frederick-vs-ja
Copy link
Contributor

This assertion failed, but I failed to reproduce the error on Godbolt...

assert(comp_ellint_2(0) == acos(-1.0) / 2);

Perhaps we can (temporarily) change this line as indicated (2 might be replaced with some suitable relative error)

assert(expect_epsilons(comp_ellint_2(0), acos(-1.0) / 2, 2));

@fsb4000
Copy link
Contributor

fsb4000 commented Dec 30, 2022

You also need to update this commit hash to f395de082eca6ee993a15f2bdb90277eda518295:

"repositoryUrl": "https://github.com/boostorg/math",
"commitHash": "db2a7cbb44a84c4c9cba62232c07f18b22bd965d"

I will be the first to say it; I did in fact contribute to this release of Boost. However, it fixes a platitude of issues as this is a bugfix release.

Therefore, I think updating to 1.81 is worth it.
@AreaZR
Copy link
Contributor Author

AreaZR commented Dec 30, 2022

Done!

@fsb4000
Copy link
Contributor

fsb4000 commented Dec 31, 2022

Perhaps we can (temporarily) change this line

@frederick-vs-ja Do we need to create an issue about this (here or maybe in boost-math repo)?

@frederick-vs-ja
Copy link
Contributor

Perhaps we can (temporarily) change this line

@frederick-vs-ja Do we need to create an issue about this (here or maybe in boost-math repo)?

I think I've reproduced the error, so I reported the issue in boost-math repo.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Jan 4, 2023
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I've verified that the commit hash corresponds to the boost-1.81.0 tag in the boost-math repo (https://github.com/boostorg/math/tags).

tests/std/tests/LWG3234_math_special_overloads/test.cpp Outdated Show resolved Hide resolved
@fsb4000
Copy link
Contributor

fsb4000 commented Jan 6, 2023

Error LNK2019: unresolved external symbol "void __cdecl std::swap<double,0>(double &,double &)" (??$swap@N$0A@@std@@YAXAEAN0@Z) referenced in function "bool __cdecl isclose<double>(double,double,int)" (??$isclose@N@@YA_NNNH@Z)

Adding #include <utility> fixed the test.

@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit fbed7ea into microsoft:main Jan 12, 2023
@StephanTLavavej
Copy link
Member

Thanks for updating the Boost.Math dependency! ✅ 🎉 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants