<xstring>: constexpr string element lifetime
#3334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've never trusted our use of `_Traits::assign` to start the lifetimes of the elements given that, err, that's not what `_Traits::assign` does. Let's use a `construct_at` loop instead, and centralize it into a helper function instead of repeating nine times. Test coverage will be in a future LLVM update. Drive-by: Use `_Traits::copy` instead of `_Traits::move` in `_Construct`. Since we're constructing a new string, we now the argument doesn't alias our content.
StephanTLavavej
approved these changes
Jan 10, 2023
strega-nil-ms
approved these changes
Jan 10, 2023
I'm happy for SSO activation to continue to use union member assignment to start the element lifetimes. This does at least suggest that EDIT: |
Address STL's review comment, and clarify the difference between _Activate_SSO_buffer and _Start_element_lifetimes.
StephanTLavavej
approved these changes
Jan 10, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for finding out how to fix these libcxx skips, and centralizing all of the duplicated code here! 😻 🚀 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've never trusted our use of
_Traits::assignto start the lifetimes of the elements given that, err, that's not what_Traits::assigndoes. Let's use aconstruct_atloop instead, and centralize it into a helper function instead of repeating nine times.Test coverage is in libcxx - 7 skips fixed!
Drive-by: Use
_Traits::copyinstead of_Traits::movein_Construct. Since we're constructing a new string, we know the argument doesn't alias our content.