Implement P2614R2 Deprecating float_denorm_style, numeric_limits::has_denorm, numeric_limits::has_denorm_loss
#3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems sufficient to deprecate the enumeration type only.
This comment was marked as resolved.
This comment was marked as resolved.
frederick-vs-ja
changed the title
float_denorm_style, numeric_limits::has_denorm, numeric_limits::has_denorm_loss and LWG-3869 Deprecate std::errc constants related to UNIX STREAMSfloat_denorm_style, numeric_limits::has_denorm, numeric_limits::has_denorm_loss
StephanTLavavej
requested changes
Feb 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Apr 14, 2023
barcharcraz
requested changes
Apr 20, 2023
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
barcharcraz
approved these changes
Apr 20, 2023
|
Thanks for implementing these C++23 deprecations and helping users improve their code! 🚀 ✅ 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3442.
I wanted to implement WG21-P2614R2 and LWG-3869 together to avoid conflict on warning numbers, butEdit: Separated to #3487.#pragma warning(disable : 4996)didn't work in modules (fixed in 17.6 Preview 3).It seems meaningful to apply the deprecation to older modes, since the changes in the upstream standard IEEE 754-2008 predated C++11.Edit: The original thought doesn't seem right.Drive-by change: remove the inclusion dependency ofEdit: Separated to #3631.<limits>on<cwchar>, which may slightly improve compiler throughput.