Implement LWG-3204 sub_match::swap only swaps the base class
#3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Feb 23, 2023
StephanTLavavej
approved these changes
Feb 23, 2023
StephanTLavavej
approved these changes
Feb 23, 2023
| @@ -627,6 +627,11 @@ public: | |||
| return _Compare(_Ptr, _Traits::length(_Ptr)); | |||
| } | |||
|
|
|||
| void swap(sub_match& _Other) noexcept(_Is_nothrow_swappable<_BidIt>::value) { | |||
| this->_Mybase::swap(_Other); | |||
There was a problem hiding this comment.
No change requested: As I mentioned on Discord, I think only _Mybase::swap(_Other); should be necessary here, but I can't bring myself to reset testing for this, given that it's not harmful and it follows the accepted resolution.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this surprisingly long-standing defect in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3412