-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LWG-3655: The INVOKE
operation and union
types
#3495
Conversation
@@ -109,6 +109,13 @@ constexpr bool test_invoke_r() { | |||
return true; | |||
} | |||
|
|||
// LWG-3655: The INVOKE operation and union types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change requested: this LWG issue resolution is being implemented unconditionally (as usual), but the test being extended here is C++23:
RUNALL_INCLUDE ..\usual_latest_matrix.lst |
This means that the product code is active for C++14/17/20, but is not being tested in those modes. We have tests that are built down to C++14 mode (e.g.
Dev11_0535636_functional_overhaul
is where INVOKE
is mostly tested).
However, I don't think this coverage needs to be moved - even with my paranoia about compiler bugs, I find it hard to imagine a compiler bug that would affect this code that would appear only in C++14/17/20 mode. Also, it's slightly annoying to test anything here in C++14 mode as all that's available there is the older/deprecated result_of
. So I'm simply noting this for future consideration.
Thanks! I've pushed a nitpicky rename and an expansion of the test coverage. FYI @CaseyCarter. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for extending |
Fixes #3424