Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds for /clr C++20 #3499

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

StephanTLavavej
Copy link
Member

Thanks to @tgani-msft's recent work, we can remove some workarounds for /clr C++20 that were introduced by #3194. This can happen immediately because /clr doesn't have GitHub test coverage yet. (I've tested this internally.)

  • After MSVC-PR-447956 "Enable new lambda parser for C++/CLI", we can remove workarounds for:
    • VSO-1663257 "/clr C++20 rejects WG21-P0428R2 Familiar template syntax for generic lambdas"
    • VSO-1665663 "/clr C++20 source_location has incorrect column information within a lambda"
  • After MSVC-PR-454044 "Enable C++20 support under /clr by default", we can:
    • Omit /d1clrcxxstd.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Feb 24, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 24, 2023 19:48
@StephanTLavavej StephanTLavavej self-assigned this Feb 24, 2023
@StephanTLavavej
Copy link
Member Author

I am a greedy kitty who is speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9a0f5b6 into microsoft:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants