Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer fill_n over fill where applicable #3578

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

AreaZR
Copy link
Contributor

@AreaZR AreaZR commented Mar 16, 2023

We can avoid doing the addition ourselves when we do this.

@AreaZR AreaZR requested a review from a team as a code owner March 16, 2023 21:08
We can avoid doing the addition ourselves when we do this.
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Mar 17, 2023
@StephanTLavavej
Copy link
Member

This is a good cleanup, thanks for finding it.

Separately, I will comment: Please avoid force-pushing branches after creating PRs, as GitHub doesn't make it easy to see what's changed. (In this case, nobody had started reviewing so it wasn't an issue, but the general principle still holds.)

Rewriting history before you create a PR is fine (either to squash all changes into a single commit, or to structure complicated changes as a series of comprehensible commits). After creating a PR, you should push ordinary commits to fix things like typos, which is what I see happened here.

We've asked you to avoid force pushes in the past, and you've acknowledged this, so I am confused as to why it keeps happening. If you have a tool that eagerly force-pushes, I recommend exploring how to configure it.

@StephanTLavavej StephanTLavavej self-assigned this Mar 23, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit ecc7e5a into microsoft:main Mar 24, 2023
@StephanTLavavej
Copy link
Member

fill_n(back_inserter(comments), 100, "Thanks! 😻🎉🚀");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants