Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Check c(begin|end) members of C++20 ranges #3612

Merged
merged 13 commits into from
Apr 7, 2023
Merged

Testing: Check c(begin|end) members of C++20 ranges #3612

merged 13 commits into from
Apr 7, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

Towards #3391.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 31, 2023 17:30
@JMazurkiewicz JMazurkiewicz mentioned this pull request Mar 31, 2023
Open
34 tasks
@StephanTLavavej StephanTLavavej added test Related to test code ranges C++20/23 ranges labels Mar 31, 2023
StephanTLavavej
StephanTLavavej requested changes Mar 31, 2023
View reviewed changes
tests/std/tests/P0896R4_views_common/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_common/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_common/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_join/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_reverse/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_views_reverse/test.cpp Show resolved Hide resolved
tests/std/tests/P0896R4_views_reverse/test.cpp Outdated Show resolved Hide resolved
@JMazurkiewicz

This comment was marked as resolved.

Sign in to view
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit adaf68c into microsoft:main Apr 7, 2023
@StephanTLavavej
Copy link
Member

Thanks for extending this test coverage even more and ensuring that the STL remains high-quality! ✨ ✅ 😺

@JMazurkiewicz JMazurkiewicz deleted the const-cxx20-views branch April 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
ranges C++20/23 ranges test Related to test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JMazurkiewicz @StephanTLavavej @strega-nil-ms