Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Implement multidimensional subscript operator #3689

Merged
merged 5 commits into from
May 24, 2023
Merged

<mdspan>: Implement multidimensional subscript operator #3689

merged 5 commits into from
May 24, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented May 10, 2023 •
edited
Loading

  • Implement multidimensional subscript operator (Clang only),
  • Remove operator() in all modes,
  • Use span as an argument to mdspan::_Index_impl,
  • Tests now use operator[indices...] when possible, operator[array{indices...}] otherwise.
  • Drive-by: address comments from my previous PRs.

@StephanTLavavej StephanTLavavej added mdspan C++23 mdspan blocked Something is preventing work on this labels May 10, 2023
@JMazurkiewicz JMazurkiewicz mentioned this pull request May 11, 2023
Merged
@CaseyCarter CaseyCarter removed the blocked Something is preventing work on this label May 18, 2023
@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review May 18, 2023 23:16
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner May 18, 2023 23:16
@JMazurkiewicz

This comment was marked as resolved.

Sign in to view
StephanTLavavej
StephanTLavavej approved these changes May 24, 2023
View reviewed changes
stl/inc/mdspan Show resolved Hide resolved
stl/inc/mdspan Show resolved Hide resolved
@StephanTLavavej StephanTLavavej merged commit c600a08 into microsoft:feature/mdspan2 May 24, 2023
@StephanTLavavej
Copy link
Member

Thanks! Merged with a couple of suggestions for later.

@JMazurkiewicz JMazurkiewicz deleted the mdspan/subscript-operator branch May 24, 2023 21:19
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request May 28, 2023
@JMazurkiewicz
Address comments from microsoft#3689
ece194b
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request May 30, 2023
@JMazurkiewicz
Address comments from microsoft#3689
b9d4395
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Jun 6, 2023
@JMazurkiewicz
Address comments from microsoft#3689
e2d7db4
@JMazurkiewicz JMazurkiewicz mentioned this pull request Jun 6, 2023
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
mdspan C++23 mdspan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JMazurkiewicz @StephanTLavavej @CaseyCarter