-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<mdspan>
: Remove old tests
#3767
Merged
StephanTLavavej
merged 14 commits into
microsoft:feature/mdspan2
from
JMazurkiewicz:mdspan/remove-old-tests
Jun 17, 2023
Merged
<mdspan>
: Remove old tests
#3767
StephanTLavavej
merged 14 commits into
microsoft:feature/mdspan2
from
JMazurkiewicz:mdspan/remove-old-tests
Jun 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_mdspan_support.hpp>`" And use `<test_mdspan_support.hpp>` instead of `"test_mdspan_support.hpp"` This reverts commit 2654405.
FYI, I edited your PR description to permalink the |
StephanTLavavej
approved these changes
Jun 16, 2023
Thanks! I pushed a conflict-free merge to pick up the recent toolset update, followed by simple changes to fix |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to remove old tests implemented by Matt Stephanson:
tests/std/tests/P0009R18_mdspan
directory,P0009R18_mdspan
that were not present in new fragmented test suite,layout_right
's constructornoexcept
specifier,test_mdspan_support.hpp
: implementget_mapping_properties
function that manually computes properties of layout mapping. This is based on Matt Stephanson'sTestMapping
function:STL/tests/std/tests/P0009R18_mdspan/test.cpp
Lines 344 to 430 in ab7bb23
<test_mdspan_support.hpp>
instead of"test_mdspan_support.hpp"
in tests,