-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutex.cpp
, cond.cpp
: Use static dispatch
#3770
Merged
Merged
Commits on Jun 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 24922f3 - Browse repository at this point
Copy the full SHA 24922f3View commit details
Commits on Jun 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e952e5a - Browse repository at this point
Copy the full SHA e952e5aView commit details
Commits on Jun 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c3114d1 - Browse repository at this point
Copy the full SHA c3114d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a212a04 - Browse repository at this point
Copy the full SHA a212a04View commit details
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 13f90f1 - Browse repository at this point
Copy the full SHA 13f90f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd49a2f - Browse repository at this point
Copy the full SHA fd49a2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3698785 - Browse repository at this point
Copy the full SHA 3698785View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5365632 - Browse repository at this point
Copy the full SHA 5365632View commit details -
=delete
native_handle()
for themutex
family and `condition_var……iable`. We never provided user-visible declarations for what they returned. It's extremely unlikely that users were successfully calling them in any useful way, so the bincompat risk of nulling out the vptrs is minimal. I am opting to `=delete` these functions, instead of simply not declaring them, so that attempted calls will have a slightly more comprehensible error message. As the TRANSITION comments note, in theory we could provide implementations that return the underlying Win32 machinery which actually would be possible to document. I am also changing `condition_variable`'s `native_handle_type` from `_Cnd_t` (an alias provided by `<xthreads.h>` for `_Cnd_internal_imp_t*`, which is forward-declared and never defined for users) to `void*` and grouping it with the function, which follows the Standard's order.
Configuration menu - View commit details
-
Copy full SHA for 589f8d7 - Browse repository at this point
Copy the full SHA 589f8d7View commit details
Commits on Jun 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0578610 - Browse repository at this point
Copy the full SHA 0578610View commit details
Commits on Jun 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 34fdc17 - Browse repository at this point
Copy the full SHA 34fdc17View commit details -
Revert "We don't actually need vptr placeholders."
This reverts commit 34fdc17.
Configuration menu - View commit details
-
Copy full SHA for a62223f - Browse repository at this point
Copy the full SHA a62223fView commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f3499b7 - Browse repository at this point
Copy the full SHA f3499b7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.