Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic cleanups for basic_string #3862

Merged
merged 26 commits into from
Aug 11, 2023
Merged

Logic cleanups for basic_string #3862

merged 26 commits into from
Aug 11, 2023

Commits on Jul 27, 2023

  1. Make string(const T*) and string(const T*, const Alloc&) adjacent

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    45e738d View commit details
    Browse the repository at this point in the history

  2. Add _NODISCARD for _String_val methods

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    9f726f9 View commit details
    Browse the repository at this point in the history

  3. make _Activate_SSO_buffer _CONSTEXPR20

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    02b90ed View commit details
    Browse the repository at this point in the history

  4. Make types of _BUF_SIZE and _ALLOC_MASK clear

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ca0953a View commit details
    Browse the repository at this point in the history

  5. Introduce _SMALL_STRING_CAPACITY; replace _BUF_SIZE - 1 with it

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ef708ed View commit details
    Browse the repository at this point in the history

  6. Refine _Large_string_engaged; find a missed usecase for it

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d3f736b View commit details
    Browse the repository at this point in the history

  7. Introduce _Entails_large_string; replace wild `_Large_string_engage… 

    …d` logic with it
    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e1ce499 View commit details
    Browse the repository at this point in the history

  8. Replace capacity-decision logic with _Entails_large_string

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e050101 View commit details
    Browse the repository at this point in the history

  9. Refine documentation of interaction part with basic_stringbuf

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    2b966c6 View commit details
    Browse the repository at this point in the history

  10. Try to improve documentation for _Mysize and _Myres

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d0c9dfc View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Replace two autos with explicit types.

    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    cb010d7 View commit details
    Browse the repository at this point in the history

  2. Introduce _Allocate_for_capacity and _Deallocate_for_capacity and… 

    … apply them wherever suitable; merge `_Start_element_lifetimes` into `_Allocate_for_capacity`
    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    28c834e View commit details
    Browse the repository at this point in the history

  3. Fix a misuse of _Large_string_engaged (which will otherwise break t… 

    …he invariant that string won't do allocations for small capacity)
    @achabense @StephanTLavavej
    achabense authored and StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5ba8339 View commit details
    Browse the repository at this point in the history

  4. Serially run the tests in Dev09_181509_tr1_inf_loop_uniform_int_ull.

    @StephanTLavavej
    StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9b729de View commit details
    Browse the repository at this point in the history

  5. Fix comment grammar.

    @StephanTLavavej
    StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2b017db View commit details
    Browse the repository at this point in the history

  6. In _Deallocate_for_capacity, pass _Old_ptr by value.

    @StephanTLavavej
    StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e600d39 View commit details
    Browse the repository at this point in the history

  7. Drop redundant public: after the removal of `_Copy_assign_val_from_… 

    …small`.
    @StephanTLavavej
    StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6f8a3cb View commit details
    Browse the repository at this point in the history

  8. Add test_string_copy_assign_pocca_sso().

    @StephanTLavavej
    StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0baefec View commit details
    Browse the repository at this point in the history

  9. Restore shrink_to_fit to allocate exactly.

    @StephanTLavavej
    StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9b0e590 View commit details
    Browse the repository at this point in the history

  10. _Reallocation_policy => _Allocation_policy

    @StephanTLavavej
    StephanTLavavej committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3a27c90 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Rename to avoid macro identifier space 

    Rename `_ALLOC_MASK`, `_SMALL_STRING_CAPACITY` and `_LEAST_ALLOCATION_SIZE` to avoid the macro identifier namespace. Comment that `_BUF_SIZE` is used by the debugger visualizer (and hence shouldn't be renamed).
    @CaseyCarter
    CaseyCarter committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6ea7f29 View commit details
    Browse the repository at this point in the history

  2. Rename _Large_string_engaged to _Large_mode_engaged 

    ... to avoid confusion about size vs. capacity since `_Large_string_engaged()` can be `true` for a very small string with a large capacity.
    @CaseyCarter
    CaseyCarter committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a2cb72b View commit details
    Browse the repository at this point in the history

  3. Expand _Entails_large_string into callsites 

    With the addition of `_SMALL_STRING_CAPACITY`, I think the expressions themselves (e.g., `_Count > _SMALL_STRING_CAPACITY`) are more readable than calls to the function.
    @CaseyCarter
    CaseyCarter committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9921deb View commit details
    Browse the repository at this point in the history

  4. "small mode" instead of "SSO mode" 

    It's more clearly the opposite of "large mode".
    @CaseyCarter
    CaseyCarter committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    84b8ced View commit details
    Browse the repository at this point in the history

  5. Rename _Buf_res and _Released_buffer::_Res 

    ... to the more descriptive `_Actual_allocation_size`.
    @CaseyCarter
    CaseyCarter committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9ed46dc View commit details
    Browse the repository at this point in the history

  6. Don't enumerate users of _Least_allocation_size 

    Grepping is quick, and this is very likely to bitrot.
    @CaseyCarter
    CaseyCarter committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    e2ac4ce View commit details
    Browse the repository at this point in the history