Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use only static_assert for _EMIT_STL_ERROR #4020

Merged
merged 2 commits into from
Sep 14, 2023
Merged

use only static_assert for _EMIT_STL_ERROR #4020

merged 2 commits into from
Sep 14, 2023

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Sep 10, 2023

Fixes #4009

It looks like this in the IDE:
изображение

@fsb4000 fsb4000 requested a review from a team as a code owner September 10, 2023 08:07
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Sep 11, 2023
@StephanTLavavej StephanTLavavej self-assigned this Sep 13, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 6aa6501 into microsoft:main Sep 14, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for improving these diagnostics! ⚠️ ❌ 🎉

@fsb4000 fsb4000 deleted the fix4009 branch September 15, 2023 00:06
@StephanTLavavej StephanTLavavej mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: _EMIT_STL_ERROR leads to uninformative error logs
3 participants
@fsb4000 @StephanTLavavej @CaseyCarter