-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<deque>
: Fix single-element insertion of deque
#4022
<deque>
: Fix single-element insertion of deque
#4022
Conversation
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/Dev10_860421_deque_push_back_pop_front/test.cpp
Outdated
Show resolved
Hide resolved
I thought carefully about these cases, and I think we have sufficient test coverage, so we can merge this without a second maintainer approval. I believe that resolving the merge conflict in this batch should be simple but I'll see. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
I've pushed a merge with |
Thanks for fixing this bug in the STL's favorite and best container! 😹 🐞 ✅ |
As said in #1023 (comment), it's non-conforming to use
rotate
which requires swappability.It seems to me that we should sometime use copy construction/assignment instead or moving, as done inNo, the requirements forvector
.deque
are more relaxed.Fixes #1023. Note that there'll be merge conflict with #4016.