Add * tags to all non-tagged configs
#4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in our test matrices. `RUNALL_CROSSLIST` forms the cross product of all lines from above with all lines from below, and from each pairing whose tag sets intersect produces a new line tagged with the intersection that defines all variables defined on either line, with values that are the concatenation of the values from `x` and `y`. Non-tagged lines are treated as if they are all tagged with the same value, and `*` is the identity element for tag set intersection. For example: ``` MEOW=A X MEOW=B Y MEOW=C * MEOW=D RUNALL_CROSSLIST WOOF=1 X,Y WOOF=2 X WOOF=3 Y MEOW=E WOOF=4 ``` is equivalent to: ``` MEOW=A WOOF=1 X MEOW=B WOOF=2 X MEOW=B WOOF=3 Y MEOW=C WOOF=2 Y MEOW="C E" WOOF=4 MEOW=D WOOF=1 X,Y MEOW=D WOOF=2 X MEOW=D WOOF=3 Y MEOW="D E" WOOF=4 ``` [microsoftGH-4052](microsoft#4052) added `*` tags to all non-leaf lines so they would properly combine with leaf configurations that have either an `ASAN` or empty tag. There's a danger of "losing" `ASAN` configurations if we add a crosslist that inadvertently matches untagged lines with `ASAN` lines. We decided that all lines should be tagged with either `ASAN` or `*` to lessen the likelihood of such a mistake.
CaseyCarter
changed the title
* tags to all non-tagged configs
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Oct 4, 2023
|
I searched carefully for any missed lines and didn't find them. |
|
There are no stealth conflicts with the Ready To Merge PRs (a few are adding |
|
I agree, this should not be problematic. I manually queued an ASAN run for good measure (https://dev.azure.com/vclibs/STL/_build/results?buildId=15321&view=results) and it is nicely green. |
⭐ 🌟 🤩 |
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Nov 29, 2023
This reverts commit 283cf32.
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Dec 4, 2023
This reverts commit 283cf32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in our test matrices.
RUNALL_CROSSLISTforms the cross product of all lines from above with all lines from below, and from each pairing whose tag sets intersect produces a new line tagged with the intersection that defines all variables defined on either line, with values that are the concatenation of the values fromxandy. Non-tagged lines are treated as if they are all tagged with the same value, and*is the identity element for tag set intersection. For example:is equivalent to:
GH-4052 added
*tags to all non-leaf lines so they would properly combine with leaf configurations that have either anASANor empty tag. There's a danger of "losing"ASANconfigurations if we add a crosslist that inadvertently matches untagged lines withASANlines. We decided that all lines should be tagged with eitherASANor*to lessen the likelihood of such a mistake.