-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADL-proof implementation of algorithms in [alg.nonmodifying] #4138
Merged
StephanTLavavej
merged 11 commits into
microsoft:main
from
frederick-vs-ja:adl-proof-alg-nonmodifying
Nov 10, 2023
Merged
ADL-proof implementation of algorithms in [alg.nonmodifying] #4138
StephanTLavavej
merged 11 commits into
microsoft:main
from
frederick-vs-ja:adl-proof-alg-nonmodifying
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Schellenberger Costa <[email protected]>
needed for [alg.nonmodifying]
StephanTLavavej
requested changes
Oct 31, 2023
This comment was marked as resolved.
This comment was marked as resolved.
tests/std/tests/GH_001596_adl_proof_algorithms/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Nov 9, 2023
Thanks for the fine-grained commits, this was very easy to review! I pushed a couple of fixes. I think it needs only one maintainer approval. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for adding defenses against our eternal nemesis, ADL! 🛡️ 📈 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #140 and #1596, separated from #4004.
The
std::search
overload taking a searcher is not yet handled. I'll created another PR for standard searchers._Adl_verify_range
is adopted from<algorithm>
: unqualified calls to_Adl_verify_range
incorrectly cause instantiation #1596 (comment) (thanks to @miscco)._STD
,_RANGES
, and::
-qualifications.::
for__std_meow
functions because_CSTD __std_meow
looks very weird to me.pair
s)._Equal_rev_pred
to avoid ADL.Notes:
<execution>
are not yet qualified, because they take either no arguments or only integers._Ubegin
and_Uend
are not qualified because they are function objects.