-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Non-exception Throwing Specifier to ranges::ssize
#4231
Add Non-exception Throwing Specifier to ranges::ssize
#4231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use GitHub's close/fix/resolve syntax (e.g. saying Fixes #4107
) in the description of this PR (instead of the commit message).
Also, it would be better to add
|
@microsoft-github-policy-service agree |
ranges::ssize
Looks great, thanks! I updated your PR description to properly link to the issue that it resolves, and updated the PR title to mention what ranges function is being changed. I think this needs only one maintainer approval. We merge PRs simultaneously to the GitHub and MSVC-internal repos, batched up in a semi-manual process to save time. Your PR will be part of the next batch, probably next week. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Copy that. (Am i supposed to reoly this?)
…---Original---
From: "Stephan T. ***@***.***>
Date: Thu, Dec 7, 2023 10:13 AM
To: ***@***.***>;
Cc: "Cai ***@***.******@***.***>;
Subject: Re: [microsoft/STL] Add Non-exception Throwing Specifier to`ranges::ssize` (PR #4231)
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks for fixing This will ship in VS 2022 17.10 Preview 1. |
Fixes #4107.
Non-exception throwing specifier added in
stl/inc/xutility:3357
Besides, some improper fomats are changed in
stl/inc/xutility