Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<numeric>: switch transform_reduce from direct list initialization to copy non-list initialization #4260

Merged
merged 7 commits into from
Jan 11, 2024
Merged

<numeric>: switch transform_reduce from direct list initialization to copy non-list initialization #4260

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b8b6d5d
To fix #4129
yqZhang4480 Dec 14, 2023
23e4264
format
yqZhang4480 Dec 14, 2023
f0187f0
add a test case related to #4129
yqZhang4480 Dec 14, 2023
9888d0e
Update test.cpp
yqZhang4480 Dec 14, 2023
4298ba9
Update tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/t…
yqZhang4480 Dec 14, 2023
4763563
Update tests/std/tests/P0024R2_parallel_algorithms_transform_reduce/t…
yqZhang4480 Dec 14, 2023
cae9d8f
Code review feedback.
StephanTLavavej Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stl/inc/execution
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4235,7 +4235,8 @@ struct _Static_partitioned_transform_reduce2 { // transformed reduction task sch
auto& _Transform_op = _This->_Transform_op;
auto _Chunk = _This->_Basis._Get_chunk(_Key);
auto _Next = _Chunk._First;
_Ty _Val{_Reduce_op(_Transform_op(*_Chunk._First), _Transform_op(*++_Next))};

_Ty _Val = _Reduce_op(_Transform_op(*_Chunk._First), _Transform_op(*++_Next));
strega-nil-ms marked this conversation as resolved.
Show resolved Hide resolved
StephanTLavavej marked this conversation as resolved.
Show resolved Hide resolved
while (++_Next != _Chunk._Last) {
_Val = _Reduce_op(_STD move(_Val), _Transform_op(*_Next));
}
Expand Down