Make join_view and join_with_view iterators default-constructible (the forgotten part of P2770R0) #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpplearner
force-pushed
the
join-iter-default-cons
branch
from
3f91c6a
to
45ca314
Compare
This comment was marked as outdated.
This comment was marked as outdated.
StephanTLavavej
approved these changes
Dec 16, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this libcxx failure and completing this paper again! 😹 😻 🛠️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2770R0 changes these iterators to be unconditionally default-constructible. I missed this part in #3466.
This was discovered by libc++ test
std/ranges/range.adaptors/range.join/range.join.iterator/ctor.default.pass.cpp.