Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coarse-grained _HAS_CXXnn instead of fine-grained __cpp_lib_MEOW #4364

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Test coarse-grained _HAS_CXXnn instead of fine-grained __cpp_lib_MEOW #4364

merged 6 commits into from
Feb 6, 2024

Conversation

cpplearner
Copy link
Contributor

From #4298 (comment):

in general, we prefer to test coarse-grained _HAS_CXXnn instead of fine-grained __cpp_lib_MEOW, once there are no compiler or mode dependencies.

@cpplearner cpplearner requested a review from a team as a code owner February 3, 2024 04:00
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Feb 3, 2024
@StephanTLavavej StephanTLavavej self-assigned this Feb 3, 2024
@StephanTLavavej StephanTLavavej removed their assignment Feb 3, 2024
@StephanTLavavej StephanTLavavej self-assigned this Feb 5, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 697d0b9 into microsoft:main Feb 6, 2024
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for simplifying these preprocessor conditions! ✨ 😸 🪄

@cpplearner cpplearner deleted the has-cxx branch February 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpplearner @StephanTLavavej